Use antialiasing when comparing pdf files #30068
Draft
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render at 600dpi and scale down to 150dpi.
6afa531 to
645322b
Compare
Perhaps this is causing the EPS failures
|
I didn't check, but did all the baselines get updated because they were in fact already slightly invalid but the errors were hidden by the low resolution? If so, does it mean that the regeneration of most baselines arising from the current work to update freetype & parts of the text rendering stack would mean that after they get merged (perhaps not so quickly...), this PR would no longer need to further update them? Perhaps as a temporary workaround (to limit baseline updates) we could have two test formats, ".pdf" and ".aa600.pdf" where only the latter would be tested after AA rasterization at 600dpi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render at 600dpi and scale down to 150dpi.
The low-resolution non-antialiased rendering is convenient in that it hides minor font differences, but it can hide actual rendering errors and cause problems. For example, #29392 needs to change multiple baseline files because of minor differences only visible because of the low-resolution rasterisation.