Add deprecation for Axes.set_thetagrids(frac). #9796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Nov 16, 2017
| @@ -1173,6 +1173,11 @@ def set_thetagrids(self, angles, labels=None, frac=None, fmt=None, | |||
|
|
|||
| ACCEPTS: sequence of floats | |||
| """ | |||
| if frac is not None: | |||
| cbook.warn_deprecated('2.1', name='frac', obj_type='parameter', | |||
There was a problem hiding this comment.
Can this be 2.2 (or maybe 2.1.1), since 2.1 has already been released?
There was a problem hiding this comment.
I put 2.1 because it technically stopped working in that version. Not sure how much effort is worth it to re-enable the functionality.
|
Can you also add a note to the whats_new or api_changes that went along with the polar update? |
tacaswell
approved these changes
Nov 20, 2017
dopplershift
approved these changes
Nov 20, 2017
|
Are there any examples of how to implement this functionality by setting the padding on the ticks? All my polar plots used frac to put the theta labels inside the plot. |
|
Never mind, got it. ax.tick_params( 'x', pad = -15 ) works for the theta axis. I can't follow it with a similar call for the y axis though such as ax.tick_params( 'y', pad = -15 ) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Using
fracis no longer possible, but replaced by setting the padding on the ticks. Unfortunately, it is not straightforward to simply restore the behaviour of this parameter within the bounds of the current implementation, since padding is now radius-independent. I think it could be done with a bit of work, but I'm not sure it'd be worth it.Closes #9744.
PR Checklist