@WHug0 - I hope you are doing well, and had a chance to familiarize yourself with the code. I will outline here changes needed for this request. I assume you know basic GitHub workflow (fork, clone, code, commit, push, pull-request) but if not let me know I will review it with you.

Regarding returning renko values, moving averages, and anything else mpf.plot() might calculate, I don't think we should return these things as the return value of the function, because mpf.plot() already has an option to return the Figure and Axes, and we should not confuse things by having the return value of mpf.plot() sometimes be plotting objects and sometimes be data.

I propose that you create a new kwarg, return_calculated_values, and the user wanting the calculated data would pass a variable containing an empty dict as the value for that kwarg, and mpf.plot() will fill that empty dict with the calculated values. Thus, for example:

 retdata = {}
 mpf.plot(df, type='renko', mav=(10,20), return_calculated_values=retdata)

The kwarg should be added to _valid_plot_kwargs() with a default value of None, and its validator should check to make sure the user passes only an empty dict.

All of the possible calculated values are available in this general vicinity of the code. These include brick_values, new_dates, mavprices, and only for the case of type=renko the variable volumes may contact calculated values (but not for other plot types). In an appropriate place near that part of the code, you can write code to insert the calculated values into the dict. Here is some pseudo code to give you an idea:

if config['return_calculated_values'] is not None:
    retdict = config['return_calculated_values']
    if ptype == 'renko':
        retdict['renko_bricks'] = brick_values
        retdict['renko_dates']  = new_dates
        if config['volume']:
            retdict[renko_volumes'] = volumes
    if mavgs is not None:
        for mav in mavgs:
             format a string like 'mav10' for a 10 period mav, etc.
             retdict['mav25'] = mavprices

That's the basic idea. Let me know if you have any questions, or if you want me to look at the code before you submit a pull request (after is fine too).

All the best. --Daniel

Uh oh!

Get renko values #63

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions