🎨 Inline render{Push,Pull}Button

Antonio Scandurra · Antonio Scandurra · commit a2718a2404e6 · 2016-06-01T14:01:25.000+02:00
diff --git a/lib/git/push-pull/push-pull-component.js b/lib/git/push-pull/push-pull-component.js
@@ -92,8 +92,14 @@ export default class PushPullComponent {
           <button className='git-PushPull-item btn' onclick={() => this.fetch()} disabled={this.viewModel.hasRequestsInFlight()}>Fetch</button>
 
           <div className='git-PushPull-item is-flexible btn-group'>
-            {this.renderPullButton()}
-            {this.renderPushButton()}
+            <button className='btn' onclick={() => this.pull()} disabled={this.viewModel.hasRequestsInFlight()}>
+              <span className='icon icon-arrow-down'/>
+              {this.labelForPullButton()}
+            </button>
+            <button className='btn' onclick={() => this.push()} disabled={this.viewModel.hasRequestsInFlight()}>
+              <span className='icon icon-arrow-up'/>
+              {this.labelForPushButton()}
+            </button>
           </div>
         </div>
         {this.renderProgress()}
@@ -103,24 +109,12 @@ export default class PushPullComponent {
     /*eslint-enable*/
   }
 
-  renderPushButton () {
-    let label = this.viewModel.getAheadCount() === 0 ? 'Push' : `Push (${this.viewModel.getAheadCount()})`
-    return (
-      <button className='btn' onclick={() => this.push()} disabled={this.viewModel.hasRequestsInFlight()}>
-        <span className='icon icon-arrow-up'/>
-        {label}
-      </button>
-    )
+  labelForPullButton () {
+    return this.viewModel.getBehindCount() === 0 ? 'Pull' : `Pull (${this.viewModel.getBehindCount()})`
   }
 
-  renderPullButton () {
-    let label = this.viewModel.getBehindCount() === 0 ? 'Pull' : `Pull (${this.viewModel.getBehindCount()})`
-    return (
-      <button className='btn' onclick={() => this.pull()} disabled={this.viewModel.hasRequestsInFlight()}>
-        <span className='icon icon-arrow-down'/>
-        {label}
-      </button>
-    )
+  labelForPushButton () {
+    return this.viewModel.getAheadCount() === 0 ? 'Push' : `Push (${this.viewModel.getAheadCount()})`
   }
 
   async performOperation (fn: () => Promise<void>): Promise<void> {
