PP-324 [#2427] refactor paragraph modifiers#2430
Draft
jiromaykin wants to merge 6 commits intonlds-para-heading-implementationfrom
Draft
PP-324 [#2427] refactor paragraph modifiers#2430jiromaykin wants to merge 6 commits intonlds-para-heading-implementationfrom
jiromaykin wants to merge 6 commits intonlds-para-heading-implementationfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nlds-para-heading-implementation #2430 +/- ##
===================================================================
Coverage ? 93.44%
===================================================================
Files ? 1209
Lines ? 47708
Branches ? 0
===================================================================
Hits ? 44582
Misses ? 3126
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a759269 to
faa8cf1
Compare
a1dd0e5 to
afb0b8e
Compare
5699fd3 to
5dc85e8
Compare
faa8cf1 to
943e590
Compare
69b1040 to
4802dbe
Compare
1da45a7 to
9e68617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove small/muted modifiers or replace them
Advice from NLDS
https://nldesignsystem.nl/richtlijnen/stijl/typografie/lettergrootte/
https://nldesignsystem.nl/richtlijnen/stijl/typografie/uitlijning/
Changed componentns:
File list on Zaak detail, needs to remain in Groningen-tested design
Issue References
closes PP-324
Checklist