Merge pull request libgit2#2719 from libgit2/cmn/fetch-twice

Vicent Marti · Vicent Marti · commit 21361cb7feeb · 2014-11-20T13:12:29.000+01:00
fetch: clear the connection data on close
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -1009,6 +1009,7 @@ static int http_close(git_smart_subtransport *subtransport)
 	git_vector_clear(&t->auth_contexts);
 
 	gitno_connection_data_free_ptrs(&t->connection_data);
+	memset(&t->connection_data, 0x0, sizeof(gitno_connection_data));
 
 	return 0;
 }
diff --git a/tests/online/fetch.c b/tests/online/fetch.c
@@ -202,3 +202,14 @@ void test_online_fetch__remote_symrefs(void)
 
 	git_remote_free(remote);
 }
+
+void test_online_fetch__twice(void)
+{
+	git_remote *remote;
+
+	cl_git_pass(git_remote_create(&remote, _repo, "test", "http://github.com/libgit2/TestGitRepository.git"));
+	cl_git_pass(git_remote_fetch(remote, NULL, NULL, NULL));
+	cl_git_pass(git_remote_fetch(remote, NULL, NULL, NULL));
+
+	git_remote_free(remote);
+}

Original file line number	Diff line number	Diff line change
`@@ -1009,6 +1009,7 @@ static int http_close(git_smart_subtransport *subtransport)`
`1009`	`1009`	`git_vector_clear(&t->auth_contexts);`
`1010`	`1010`
`1011`	`1011`	`gitno_connection_data_free_ptrs(&t->connection_data);`
	`1012`	`+ memset(&t->connection_data, 0x0, sizeof(gitno_connection_data));`
`1012`	`1013`
`1013`	`1014`	`return 0;`
`1014`	`1015`	`}`