index, iterator, fetchhead: plug leaks

carlosmn · carlosmn · commit 24fa21f38e15 · 2015-06-26T19:00:33.000+02:00
diff --git a/src/iterator.c b/src/iterator.c
@@ -1926,6 +1926,9 @@ int git_iterator_walk(
 	}
 
 done:
+	git__free(iterator_item);
+	git__free(cur_items);
+
 	if (error == GIT_ITEROVER)
 		error = 0;
 
diff --git a/tests/fetchhead/nonetwork.c b/tests/fetchhead/nonetwork.c
@@ -394,4 +394,7 @@ void test_fetchhead_nonetwork__create_when_refpecs_given(void)
 	cl_git_pass(git_repository_fetchhead_foreach(g_repo, find_master, NULL));
 	cl_assert(find_master_called);
 	cl_assert(found_master);
+
+	git_remote_free(remote);
+	git_buf_free(&path);
 }
diff --git a/tests/index/racy.c b/tests/index/racy.c
@@ -108,7 +108,7 @@ void test_index_racy__empty_file_after_smudge(void)
 	const git_index_entry *entry;
 
 	/* Make sure we do have a timestamp */
-	cl_git_pass(git_repository_index(&index, g_repo));
+	cl_git_pass(git_repository_index__weakptr(&index, g_repo));
 	cl_git_pass(git_index_write(index));
 
 	cl_git_pass(git_buf_joinpath(&path, git_repository_workdir(g_repo), "A"));
@@ -140,4 +140,7 @@ void test_index_racy__empty_file_after_smudge(void)
 
 	cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, index, NULL));
 	cl_assert_equal_i(1, git_diff_num_deltas(diff));
+
+	git_buf_free(&path);
+	git_diff_free(diff);
 }

Original file line number	Diff line number	Diff line change
`@@ -394,4 +394,7 @@ void test_fetchhead_nonetwork__create_when_refpecs_given(void)`
`394`	`394`	`cl_git_pass(git_repository_fetchhead_foreach(g_repo, find_master, NULL));`
`395`	`395`	`cl_assert(find_master_called);`
`396`	`396`	`cl_assert(found_master);`
	`397`	`+`
	`398`	`+ git_remote_free(remote);`
	`399`	`+ git_buf_free(&path);`
`397`	`400`	`}`