Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 2520573

Browse files
committed
test: make sure we retry the auth callback on all platforms
We were missing this test on Windows, which meant we didn't notice that we never fixed the single authentication attempt it tries, nor its wrong return code. Enable this for the unix platforms as well over HTTP. We previously were doing it locally but disabled it on OS X due to issues with its sshd not accepting password authentication.
1 parent 9b3fc89 commit 2520573

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

appveyor.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,8 @@ build_script:
3636
- cmd: |
3737
if "%GENERATOR%"=="MSYS Makefiles" (C:\MinGW\msys\1.0\bin\sh --login /c/projects/libgit2/script/appveyor-mingw.sh)
3838
test_script:
39-
- ps: ctest -V .
39+
- ps: |
40+
ctest -V .
41+
$env:GITTEST_REMOTE_URL="https://github.com/libgit2/non-existent"
42+
$env:GITTEST_REMOTE_USER="libgit2test"
43+
.\Debug\libgit2_clar -sonline::clone::cred_callback

script/cibuild.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,7 @@ if [ -e ./libgit2_clar ]; then
5656
./libgit2_clar -sonline::clone::cred_callback || exit $?
5757
fi
5858
fi
59+
60+
export GITTEST_REMOTE_URL="https://github.com/libgit2/non-existent"
61+
export GITTEST_REMOTE_USER="libgit2test"
62+
./libgit2_clar -sonline::clone::cred_callback || exit $?

0 commit comments

Comments
 (0)