Merge pull request libgit2#3631 from ethomson/giterr_fixups

carlosmn · carlosmn · commit 43955927e4b4 · 2016-02-23T22:27:36.000+01:00
Minor `giterr` fixups
diff --git a/include/git2/errors.h b/include/git2/errors.h
@@ -126,11 +126,6 @@ GIT_EXTERN(void) giterr_clear(void);
  * This error message is stored in thread-local storage and only applies
  * to the particular thread that this libgit2 call is made from.
  *
- * NOTE: Passing the `error_class` as GITERR_OS has a special behavior: we
- * attempt to append the system default error message for the last OS error
- * that occurred and then clear the last error.  The specific implementation
- * of looking up and clearing this last OS error will vary by platform.
- *
  * @param error_class One of the `git_error_t` enum above describing the
  *                    general subsystem that is responsible for the error.
  * @param string The formatted error message to keep
diff --git a/src/unix/map.c b/src/unix/map.c
@@ -17,7 +17,7 @@ int git__page_size(size_t *page_size)
 {
 	long sc_page_size = sysconf(_SC_PAGE_SIZE);
 	if (sc_page_size < 0) {
-		giterr_set_str(GITERR_OS, "Can't determine system page size");
+		giterr_set(GITERR_OS, "can't determine system page size");
 		return -1;
 	}
 	*page_size = (size_t) sc_page_size;

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ int git__page_size(size_t *page_size)`
`17`	`17`	`{`
`18`	`18`	`long sc_page_size = sysconf(_SC_PAGE_SIZE);`
`19`	`19`	`if (sc_page_size < 0) {`
`20`		`- giterr_set_str(GITERR_OS, "Can't determine system page size");`
	`20`	`+ giterr_set(GITERR_OS, "can't determine system page size");`
`21`	`21`	`return -1;`
`22`	`22`	`}`
`23`	`23`	`*page_size = (size_t) sc_page_size;`