Fix bug in git_smart__push: push_transfer_progress cb is never called

dleehr · carlosmn · commit 5470fd6d768c · 2015-09-03T11:10:19.000+02:00
The conditional checked cbs-&gt;transfer_progress then used the value in cbs-&gt;push_transfer_progress. In both cases it should be push_transfer_progress
diff --git a/src/transports/smart_protocol.c b/src/transports/smart_protocol.c
@@ -957,7 +957,7 @@ int git_smart__push(git_transport *transport, git_push *push, const git_remote_c
 
 	packbuilder_payload.pb = push->pb;
 
-	if (cbs && cbs->transfer_progress) {
+	if (cbs && cbs->push_transfer_progress) {
 		packbuilder_payload.cb = cbs->push_transfer_progress;
 		packbuilder_payload.cb_payload = cbs->payload;
 	}

Original file line number	Diff line number	Diff line change
`@@ -957,7 +957,7 @@ int git_smart__push(git_transport transport, git_push push, const git_remote_c`
`957`	`957`
`958`	`958`	`packbuilder_payload.pb = push->pb;`
`959`	`959`
`960`		`- if (cbs && cbs->transfer_progress) {`
	`960`	`+ if (cbs && cbs->push_transfer_progress) {`
`961`	`961`	`packbuilder_payload.cb = cbs->push_transfer_progress;`
`962`	`962`	`packbuilder_payload.cb_payload = cbs->payload;`
`963`	`963`	`}`