fix memory leak in refspec.c on errors.

jeffhostetler · jeffhostetler · commit 64e6b5b0350f · 2015-06-30T09:41:17.000-04:00
diff --git a/src/refspec.c b/src/refspec.c
@@ -142,6 +142,7 @@ int git_refspec__parse(git_refspec *refspec, const char *input, bool is_fetch)
         giterr_set(
                 GITERR_INVALID,
                 "'%s' is not a valid refspec.", input);
+        git_refspec__free(refspec);
 	return -1;
 }
 
@@ -153,6 +154,8 @@ void git_refspec__free(git_refspec *refspec)
 	git__free(refspec->src);
 	git__free(refspec->dst);
 	git__free(refspec->string);
+
+	memset(refspec, 0x0, sizeof(git_refspec));
 }
 
 const char *git_refspec_src(const git_refspec *refspec)

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ int git_refspec__parse(git_refspec refspec, const char input, bool is_fetch)`
`142`	`142`	`giterr_set(`
`143`	`143`	`GITERR_INVALID,`
`144`	`144`	`"'%s' is not a valid refspec.", input);`
	`145`	`+ git_refspec__free(refspec);`
`145`	`146`	`return -1;`
`146`	`147`	`}`
`147`	`148`
`@@ -153,6 +154,8 @@ void git_refspec__free(git_refspec *refspec)`
`153`	`154`	`git__free(refspec->src);`
`154`	`155`	`git__free(refspec->dst);`
`155`	`156`	`git__free(refspec->string);`
	`157`	`+`
	`158`	`+ memset(refspec, 0x0, sizeof(git_refspec));`
`156`	`159`	`}`
`157`	`160`
`158`	`161`	`const char git_refspec_src(const git_refspec refspec)`