transports: smart: fix memory leak on OOM path

pks-t · pks-t · commit 704554cdf07c · 2016-02-18T20:50:33.000+01:00
diff --git a/src/transports/smart_protocol.c b/src/transports/smart_protocol.c
@@ -108,6 +108,7 @@ static int append_symref(const char **out, git_vector *symrefs, const char *ptr)
 		if (giterr_last()->klass != GITERR_NOMEMORY)
 			goto on_invalid;
 
+		git__free(mapping);
 		return error;
 	}
 
@@ -120,6 +121,7 @@ static int append_symref(const char **out, git_vector *symrefs, const char *ptr)
 on_invalid:
 	giterr_set(GITERR_NET, "remote sent invalid symref");
 	git_refspec__free(mapping);
+	git__free(mapping);
 	return -1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ static int append_symref(const char *out, git_vector symrefs, const char *ptr)`
`108`	`108`	`if (giterr_last()->klass != GITERR_NOMEMORY)`
`109`	`109`	`goto on_invalid;`
`110`	`110`
	`111`	`+ git__free(mapping);`
`111`	`112`	`return error;`
`112`	`113`	`}`
`113`	`114`
`@@ -120,6 +121,7 @@ static int append_symref(const char *out, git_vector symrefs, const char *ptr)`
`120`	`121`	`on_invalid:`
`121`	`122`	`giterr_set(GITERR_NET, "remote sent invalid symref");`
`122`	`123`	`git_refspec__free(mapping);`
	`124`	`+ git__free(mapping);`
`123`	`125`	`return -1;`
`124`	`126`	`}`
`125`	`127`