refs::create: strict object creation on by default

Edward Thomson · Edward Thomson · commit b6130fe15e3a · 2016-04-11T15:58:58.000-04:00
When we turned strict object creation validation on by default, we
forgot to inform the refs::create tests of this.  They, in fact,
believed that strict object creation was off by default.  As a result,
their cleanup function went and turned strict object creation off for
the remaining tests.
diff --git a/tests/refs/create.c b/tests/refs/create.c
@@ -19,7 +19,7 @@ void test_refs_create__cleanup(void)
 {
    cl_git_sandbox_cleanup();
 
-	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0));
+	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1));
 }
 
 void test_refs_create__symbolic(void)
@@ -122,7 +122,7 @@ void test_refs_create__oid(void)
 }
 
 /* Can by default create a reference that targets at an unknown id */
-void test_refs_create__oid_unknown_succeeds_by_default(void)
+void test_refs_create__oid_unknown_succeeds_without_strict(void)
 {
 	git_reference *new_reference, *looked_up_ref;
 	git_oid id;
@@ -131,6 +131,8 @@ void test_refs_create__oid_unknown_succeeds_by_default(void)
 
 	git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644");
 
+	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0));
+
 	/* Create and write the new object id reference */
 	cl_git_pass(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL));
 	git_reference_free(new_reference);
@@ -141,7 +143,7 @@ void test_refs_create__oid_unknown_succeeds_by_default(void)
 }
 
 /* Strict object enforcement enforces valid object id */
-void test_refs_create__oid_unknown_fails_strict_mode(void)
+void test_refs_create__oid_unknown_fails_by_default(void)
 {
 	git_reference *new_reference, *looked_up_ref;
 	git_oid id;
@@ -150,8 +152,6 @@ void test_refs_create__oid_unknown_fails_strict_mode(void)
 
 	git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644");
 
-	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1));
-
 	/* Create and write the new object id reference */
 	cl_git_fail(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL));
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ void test_refs_create__cleanup(void)`
`19`	`19`	`{`
`20`	`20`	`cl_git_sandbox_cleanup();`
`21`	`21`
`22`		`- cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0));`
	`22`	`+ cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1));`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`void test_refs_create__symbolic(void)`
`@@ -122,7 +122,7 @@ void test_refs_create__oid(void)`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`/* Can by default create a reference that targets at an unknown id */`
`125`		`-void test_refs_create__oid_unknown_succeeds_by_default(void)`
	`125`	`+void test_refs_create__oid_unknown_succeeds_without_strict(void)`
`126`	`126`	`{`
`127`	`127`	`git_reference new_reference, looked_up_ref;`
`128`	`128`	`git_oid id;`
`@@ -131,6 +131,8 @@ void test_refs_create__oid_unknown_succeeds_by_default(void)`
`131`	`131`
`132`	`132`	`git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644");`
`133`	`133`
	`134`	`+ cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0));`
	`135`	`+`
`134`	`136`	`/* Create and write the new object id reference */`
`135`	`137`	`cl_git_pass(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL));`
`136`	`138`	`git_reference_free(new_reference);`
`@@ -141,7 +143,7 @@ void test_refs_create__oid_unknown_succeeds_by_default(void)`
`141`	`143`	`}`
`142`	`144`
`143`	`145`	`/* Strict object enforcement enforces valid object id */`
`144`		`-void test_refs_create__oid_unknown_fails_strict_mode(void)`
	`146`	`+void test_refs_create__oid_unknown_fails_by_default(void)`
`145`	`147`	`{`
`146`	`148`	`git_reference new_reference, looked_up_ref;`
`147`	`149`	`git_oid id;`
`@@ -150,8 +152,6 @@ void test_refs_create__oid_unknown_fails_strict_mode(void)`
`150`	`152`
`151`	`153`	`git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644");`
`152`	`154`
`153`		`- cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1));`
`154`		`-`
`155`	`155`	`/* Create and write the new object id reference */`
`156`	`156`	`cl_git_fail(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL));`
`157`	`157`