Merge pull request libgit2#2389 from arthurschreiber/arthur/set-error-when-no-remote-found

Vicent Marti · Vicent Marti · commit bccb36ebf9d9 · 2014-06-03T17:25:59.000+02:00
Remote: Set an error when a remote cannot be found.
diff --git a/src/remote.c b/src/remote.c
@@ -403,6 +403,7 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
 
 	if (!optional_setting_found) {
 		error = GIT_ENOTFOUND;
+		giterr_set(GITERR_CONFIG, "Remote '%s' does not exist.", name);
 		goto cleanup;
 	}
 
diff --git a/tests/network/remote/remotes.c b/tests/network/remote/remotes.c
@@ -60,6 +60,15 @@ void test_network_remote_remotes__pushurl(void)
 	cl_assert(git_remote_pushurl(_remote) == NULL);
 }
 
+void test_network_remote_remotes__error_when_not_found(void)
+{
+	git_remote *r;
+	cl_git_fail_with(git_remote_load(&r, _repo, "does-not-exist"), GIT_ENOTFOUND);
+
+	cl_assert(giterr_last() != NULL);
+	cl_assert(giterr_last()->klass == GITERR_CONFIG);
+}
+
 void test_network_remote_remotes__error_when_no_push_available(void)
 {
 	git_remote *r;

Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,7 @@ int git_remote_load(git_remote *out, git_repository repo, const char *name)`
`403`	`403`
`404`	`404`	`if (!optional_setting_found) {`
`405`	`405`	`error = GIT_ENOTFOUND;`
	`406`	`+ giterr_set(GITERR_CONFIG, "Remote '%s' does not exist.", name);`
`406`	`407`	`goto cleanup;`
`407`	`408`	`}`
`408`	`409`