Empty identifiers must be disallowed

Ocramius · Ocramius · commit dbcdc1d42a53 · 2016-07-07T20:57:49.000+02:00
diff --git a/lib/Doctrine/ORM/UnitOfWork.php b/lib/Doctrine/ORM/UnitOfWork.php
@@ -1400,7 +1400,7 @@ public function addToIdentityMap($entity)
         $classMetadata = $this->em->getClassMetadata(get_class($entity));
         $identifier    = $this->entityIdentifiers[spl_object_hash($entity)];
 
-        if (in_array(null, $identifier, true)) {
+        if (empty($identifier) || in_array(null, $identifier, true)) {
             throw ORMInvalidArgumentException::entityWithoutIdentity($classMetadata->name, $entity);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1400,7 +1400,7 @@ public function addToIdentityMap($entity)`
`1400`	`1400`	`$classMetadata = $this->em->getClassMetadata(get_class($entity));`
`1401`	`1401`	`$identifier = $this->entityIdentifiers[spl_object_hash($entity)];`
`1402`	`1402`
`1403`		`- if (in_array(null, $identifier, true)) {`
	`1403`	`+ if (empty($identifier) \|\| in_array(null, $identifier, true)) {`
`1404`	`1404`	`throw ORMInvalidArgumentException::entityWithoutIdentity($classMetadata->name, $entity);`
`1405`	`1405`	`}`
`1406`	`1406`