Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

chore: CLI should not check for .cortexrc's supportedEngines #1962

@gau-nernst

Description

@gau-nernst

Cortex version

default_version (local build from source)

Describe the issue and expected behaviour

I tried changing kPythonEngine to "python" (instead of "python-engine") then faced the following issue (why I wanted to change the name is not too important)

./cortex engines install python
The following argument was not expected: python
Run with --help for more information.

The issue is the the CLI checks for supported engines against .cortexrc, which still only has the old engine names -> discrepancy between binary and .cortexrc. This is also problematic if we add a new engine in the future -> .cortexrc doesn't have the new engine name -> doesn't allow existing users to install.

I don't see a good reason to save supportedEngines in .cortex. It should always be referenced against the binary instead (either cortex or cortex-server) -> single source of truth

Steps to Reproduce

No response

Screenshots / Logs

No response

What is your OS?

  • Windows
  • Mac Silicon
  • Mac Intel
  • Linux / Ubuntu

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)

Hardware Specs eg OS version, GPU

No response

Metadata

Metadata

Assignees

Labels

type: bugSomething isn't working

Type

Projects

Status

QA

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions