Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

epic: Migrate repo to C++ 17 #2130

@dan-menlo

Description

@dan-menlo

Goal

To have a consistant C++ version for supporting every compiler and platform

Success Criteria

Build should pass with COTEX_CQA=ON cmake flag

Key Decisions

Our original decision was to choose between C++ 17 and C++ 20:

  • Not all compiler support C++ 20, especially on Linux

Why are we not sticking with what we did before? (hybrid C++ 17 and 20?)

  • Compiler would complain if we used C++ 20 in C++ 17
  • We want to make it consistent across all platforms
  • Having a mono C++17 repo helps us detect memory leaks, corruption issues, SegFaults, dangling pointers etc

When do we anticipate moving to C++ 20?

  • When llama.cpp moves to C++20
  • Linux compiler support sucks
  • Key question: do we need C++ 20? (or 23)

Key question: what is the OS we wish to support?

  • If we run our own server, we should use the latest C++ version
  • Question 1: Raspberry Pi?
  • Question 2: Scaled Inference (i.e. efficiency)

Tasklist

  • Change designated initialization to list initialization (which is supported by C++17)
  • Address and remove unused variables and functions

Metadata

Metadata

Assignees

Labels

type: epicA major feature or initiative

Type

No type

Projects

Status

Completed

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions