This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: correct path to work with data folder structure #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
reviewed
Sep 6, 2024
engine/main.cc
Outdated
| @@ -4,7 +4,7 @@ | |||
| #include "controllers/command_line_parser.h" | |||
| #include "cortex-common/cortexpythoni.h" | |||
| #include "utils/archive_utils.h" | |||
| #include "utils/config_yaml_utils.h" | |||
| // #include "utils/config_yaml_utils.h" | |||
namchuai
reviewed
Sep 6, 2024
engine/utils/config_yaml_utils.h
Outdated
| @@ -13,7 +13,7 @@ struct CortexConfig { | |||
| std::string port; | |||
| }; | |||
|
|
|||
| const std::string kCortexFolderName = "cortexcpp"; | |||
| const std::string kCortexFolderName = ".cortexcpp"; | |||
There was a problem hiding this comment.
Hmm, not sure if we want to hide this folder from user.
namchuai
reviewed
Sep 6, 2024
engine/utils/file_manager_utils.h
Outdated
| std::filesystem::path data_folder_path; | ||
| if (!config.dataFolderPath.empty()) { | ||
| data_folder_path = | ||
| std::filesystem::path(config.dataFolderPath) / ".cortexcpp"; |
There was a problem hiding this comment.
since default dataFolderPath is having kCortexFolderName already, do we need to add another .cortexcpp under it?
namchuai
approved these changes
Sep 6, 2024
nguyenhoangthuan99
approved these changes
Sep 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1121
Only solved issue for llamacpp on MacOS and Linux/Windows CPU build
Need #1047 to make others work