Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: models.cc: symlinked model deletion shouldn't remove original file #1918

Merged

Conversation

ohaiibuzzle
Copy link
Contributor

@ohaiibuzzle ohaiibuzzle commented Feb 3, 2025

Describe Your Changes

Set the branch name property for symlinked models to imported

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@ohaiibuzzle ohaiibuzzle force-pushed the ohaiibuzzle/fix/symlink-deletion branch from f6df51e to f704700 Compare February 3, 2025 19:32
@ohaiibuzzle ohaiibuzzle force-pushed the ohaiibuzzle/fix/symlink-deletion branch from f704700 to 22b9b76 Compare February 4, 2025 03:17
@imtuyethan
Copy link
Contributor

imtuyethan commented Feb 4, 2025

Copy link
Contributor

@vansangpfiev vansangpfiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@vansangpfiev vansangpfiev merged commit d05e8e4 into menloresearch:dev Feb 5, 2025
7 of 8 checks passed
vansangpfiev added a commit that referenced this pull request Feb 5, 2025
vansangpfiev added a commit that referenced this pull request Feb 10, 2025
* feat: AMD hardware API (#1797)

* feat: add amd gpu windows

* chore: remove unused code

* feat: get amd gpus

* fix: clean

* chore: cleanup

* fix: set activate

* fix: build windows

* feat: linux

* fix: add patches

* fix: map cuda gpus

* fix: build

* chore: docs

* fix: build

* chore: clean up

* fix: build

* fix: build

* chore: pack vulkan windows

* chore: vulkan linux

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: add cpu usage (#1868)

Co-authored-by: vansangpfiev <[email protected]>

* fix: PATCH method for Thread and Messages management (#1923)

Co-authored-by: vansangpfiev <[email protected]>

* fix: ignore compute_cap if not present (#1866)

* fix: ignore compute_cap if not present

* fix: correct gpu info

* fix: remove check for toolkit version

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: models.cc: symlinked model deletion shouldn't remove original file (#1918)

Co-authored-by: vansangpfiev <[email protected]>

---------

Co-authored-by: vansangpfiev <[email protected]>
Co-authored-by: OHaiiBuzzle <[email protected]>
vansangpfiev added a commit that referenced this pull request Feb 18, 2025
* feat: AMD hardware API (#1797)

* feat: add amd gpu windows

* chore: remove unused code

* feat: get amd gpus

* fix: clean

* chore: cleanup

* fix: set activate

* fix: build windows

* feat: linux

* fix: add patches

* fix: map cuda gpus

* fix: build

* chore: docs

* fix: build

* chore: clean up

* fix: build

* fix: build

* chore: pack vulkan windows

* chore: vulkan linux

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: add cpu usage (#1868)

Co-authored-by: vansangpfiev <[email protected]>

* fix: PATCH method for Thread and Messages management (#1923)

Co-authored-by: vansangpfiev <[email protected]>

* fix: ignore compute_cap if not present (#1866)

* fix: ignore compute_cap if not present

* fix: correct gpu info

* fix: remove check for toolkit version

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: models.cc: symlinked model deletion shouldn't remove original file (#1918)

Co-authored-by: vansangpfiev <[email protected]>

* fix: correct gpu info list (#1944)

* fix: correct gpu info list

* chore: cleanup

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: gpu: filter out llvmpipe

* fix: add vendor in gpu info (#1952)

Co-authored-by: vansangpfiev <[email protected]>

* fix: correct get server name method (#1953)

Co-authored-by: vansangpfiev <[email protected]>

* fix: map nvidia and vulkan uuid (#1954)

Co-authored-by: vansangpfiev <[email protected]>

* fix: permission issue for default drogon uploads folder (#1870)

Co-authored-by: vansangpfiev <[email protected]>

* chore: change timeout

* fix: make get hardware info function thread-safe (#1956)

Co-authored-by: vansangpfiev <[email protected]>

* fix: cache data for gpu information (#1959)

* fix: wrap vulkan gpu function

* fix: init

* fix: cpu usage

* fix: build windows

* fix: buld macos

---------

Co-authored-by: vansangpfiev <[email protected]>

* fix: handle path with space (#1963)

* fix: unload engine before updating (#1970)

Co-authored-by: sangjanai <[email protected]>

* fix: auto-reload model for remote engine (#1971)

Co-authored-by: sangjanai <[email protected]>

* fix: use updated configuration for remote model when reload (#1972)

Co-authored-by: sangjanai <[email protected]>

* fix: correct engine interface order (#1974)

Co-authored-by: sangjanai <[email protected]>

* fix: improve error handling for remote engine (#1975)

Co-authored-by: sangjanai <[email protected]>

* fix: temporarily remove model setting recommendation (#1977)

Co-authored-by: sangjanai <[email protected]>

---------

Co-authored-by: vansangpfiev <[email protected]>
Co-authored-by: OHaiiBuzzle <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants