This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: filter out llvmpipe #1949
Merged
fix: filter out llvmpipe #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: correct gpu info list * chore: cleanup --------- Co-authored-by: vansangpfiev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to improve GPU information handling and code readability in the
enginemodule. The most important changes include adding a condition to append GPU information only iftotal_vramis greater than zero, renaming variables for better readability, and enhancing the logic to handle GPU information from different sources.Improvements to GPU Information Handling:
engine/common/hardware_common.h: Added a condition to append GPU information to the result only iftotal_vramis greater than zero.Code Readability Enhancements:
engine/utils/hardware/gpu/vulkan/vulkan_gpu.h: Renamed variables fromavailableExtensionstoavailable_extensionsfor better readability and consistency.Enhancements to GPU Information Logic:
engine/utils/hardware/gpu_info.h: Modified the logic to determine whether to use Vulkan information by introducing theuse_vulkan_infoflag and returning appropriate GPU information based on its value. [1] [2]Fixes Issues
Self Checklist