This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: inherit current env vars when spawning subprocess on macos #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
approved these changes
Feb 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Currently only Linux inherits current env vars when spawning subprocess. Seems like Linux automatically detects
environvariable. For MacOS, simply declare an extern variable will do the trick. Hence, this PR makes the behavior ofSpawnProcess()more consistent across platforms. (We will need to fix it for Windows too...)This will be required for my future work on Python engine.
Self Checklist