This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: remove unused fields for remote model config #2040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request focuses on simplifying the
RemoteModelConfig
structure and removing unused fields and methods related to transformation requests and responses. The changes span multiple files, includingmodel_config.h
,remote_engine.cc
, andremote_engine.h
.Simplification of
RemoteModelConfig
structure:engine/config/model_config.h
: Removed unused fieldstransform_req
,transform_resp
,metadata
, andheader_template
fromRemoteModelConfig
. Updated theLoadFromJson
,ToJson
, and other related methods to reflect these removals. [1] [2] [3] [4] [5] [6] [7]Removal of transformation request and response handling:
engine/extensions/remote-engine/remote_engine.cc
: Removed handling oftransform_req
andtransform_resp
in various methods, includingMakeStreamingChatCompletionRequest
,MakeChatCompletionRequest
,LoadModelConfig
,LoadModel
, andHandleChatCompletion
. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Update to
ModelConfig
struct:engine/extensions/remote-engine/remote_engine.h
: Removedapi_key
,transform_req
, andtransform_resp
fields from theModelConfig
struct.Fixes Issues
Self Checklist