This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: skip main branch for cortexso model source if has metadata.yml #2042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes changes to the
ModelSourceService
andhuggingface_utils
files to improve error handling and streamline the process of skipping certain branches. The most important changes are listed below:Error Handling Improvements:
engine/utils/huggingface_utils.h
: Changed the return type ofGetModelAuthorCortexsoHub
fromstd::optional<std::string>
tocpp::result<std::string, std::string>
to better handle errors and provide more informative error messages.Code Simplification:
engine/services/model_source_service.cc
: Updated theAddCortexsoRepo
method to use the newcpp::result
return type forGetModelAuthorCortexsoHub
, ensuring that the author is correctly assigned and errors are handled properly.engine/services/model_source_service.cc
: Added a check to skip the "main" branch if there are no errors with the model author, reducing unnecessary processing.Fixes Issues
Self Checklist