This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: context length for model import #2043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to the
engine/config/gguf_parser.cc
andengine/services/model_service.cc
files to improve the handling of model configuration and metadata. The most important changes are grouped by theme below:Code Simplification and Cleanup:
#include <filesystem>
directive to the correct position inengine/config/gguf_parser.cc
to maintain proper alphabetical order of includes.Error Handling:
ReadString
method to improve readability.Model Configuration:
max_tokens
andctx_len
in theModelConfigFromMetadata
method to directly usemax_tokens
instead of applying a minimum function.max_tokens
to the JSON data in theStartModel
method to ensure it is included in the model configuration. [1] [2]Fixes Issues
Self Checklist