This repository was archived by the owner on Jul 4, 2025. It is now read-only.
feat: improvements to subprocess functionality #2047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR was originally from #2010. I open this PR to merge the changes for subprocess functionality and keep #2010 smaller / more manageable. The improvements here will be used by my Python engine.
cpp::result
(instead of -1) to explicitly signal error when spawning process. This also addresses the problem thatpid_t
on Windows is DWORD i.e. unsigned int, which may lead to unexpected behavior if we use -1ProcessInfo
struct to clean up resources after process termination (right now only used by Windows to close handles)IsProcessAlive()
on Unix.kill(pid, 0)
will return 0 (success) if the process has terminated but not reaped (i.e. exit status is still stored in process table). Hence, usingwaitpid(pid, NULL, WNOHANG)
is more reliable.Fixes Issues
Self Checklist