Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: delete model for remote engine #2105

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request includes changes to the ModelService::DeleteModel method in the engine/services/model_service.cc file. The most important changes involve adding a condition to handle the removal of YAML files for remote engines.

Changes in ModelService::DeleteModel:

  • Added a condition to check if the engine is remote using engine_svc_->IsRemoteEngine(mc.engine). If true, the YAML file is removed and a log message is printed.
  • Ensured the existing logic for removing YAML files is executed only for non-remote engines.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev merged commit c65a632 into main Mar 11, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/delete-remote-model branch March 11, 2025 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants