This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: get models for anthropic and cohere #2115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes changes to the
remote-engine
component in theengine/extensions
directory to improve the handling of API key headers and remove specific engine-related constants and logic. The most important changes include refactoring header handling, removing special handling for thekAnthropicEngine
, and cleaning up unused constants.Improvements to header handling:
engine/extensions/remote-engine/remote_engine.cc
: Refactored theMakeGetModelsRequest
method to use a more flexible approach for replacing header placeholders using an unordered map and a loop to append headers.Codebase simplification:
engine/extensions/remote-engine/remote_engine.cc
: Removed the special handling for thekAnthropicEngine
in theGetRemoteModels
method, simplifying the code path for empty URLs.engine/utils/engine_constants.h
: Removed unused constantskOpenAiEngine
andkAnthropicEngine
to clean up the codebase.Fixes Issues
Self Checklist