Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

feat: allow to configure api_keys by cli #2154

Merged
merged 3 commits into from
Mar 20, 2025
Merged

feat: allow to configure api_keys by cli #2154

merged 3 commits into from
Mar 20, 2025

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Mar 20, 2025 •
edited
Loading

Describe Your Changes

  • Allow to configure api_keys via CLI, in case of api_keys we don't start server like other parameters
  • /v1/configs requires api_key header to access
  • Syntax: `cortex config --api_keys "api_key1, api_key2"
  • To support Jan use-case

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

qnixsynapse
qnixsynapse reviewed Mar 20, 2025
View reviewed changes
gau-nernst
gau-nernst approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@gau-nernst gau-nernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need some clarifications

qnixsynapse
qnixsynapse approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@qnixsynapse qnixsynapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me so far.

@vansangpfiev vansangpfiev merged commit 9b0e34b into main Mar 20, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/configs branch March 20, 2025 10:04
@prabirshrestha
Copy link

Is there a doc on how to set this when starting via docker?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qnixsynapse qnixsynapse qnixsynapse approved these changes

@gau-nernst gau-nernst gau-nernst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vansangpfiev @prabirshrestha @qnixsynapse @gau-nernst @sangjanai