This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: prevent unlimited loop due to invalid filename in path #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gau-nernst
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
No more hang, though I still think it's better to sanitize the filename string itself (checks including, but not limited to, no /), instead of trying to parse it as path and make sure it falls under cortex directory.
Approve to unblock. You can add test if you have time. Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
/v1/files/invalid filename will hang the server #2153Self Checklist