This repository was archived by the owner on Jul 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enhancement: Use XDG directory specification on Linux * Use C++ type safety and a bit refactoring * Ensure parent directory for config file exists in CreateConfigIfNotExist() * Set XDG helper function name to GetXDGDirectoryPath * E2E: Test XDG directory folder path on Linux * Remove extra empty line
* fix: docker CI * fix: create cortexcpp folder --------- Co-authored-by: sangjanai <[email protected]>
Co-authored-by: vansangpfiev <[email protected]>
* bug/feat: improve subprocess * log subprocess command for easier debugging
) * Add a new header file for normalize engine * Add normalize_engine.cc and update normalize_engine.h * chore: remove usage of anonymouse namespace --------- Co-authored-by: vansangpfiev <[email protected]>
Co-authored-by: vansangpfiev <[email protected]>
#2030) * feat: implement input validation to allow only valid numeric selections * chore:refactor function name to follow coding conventions --------- Co-authored-by: vansangpfiev <[email protected]>
* test: add e2e post default engine * test: fix ci * test: update the variant non-cuda --------- Co-authored-by: Harry Le <[email protected]>
* fix: add simple authentication * fix: exclude v1/configs --------- Co-authored-by: sangjanai <[email protected]>
Co-authored-by: sangjanai <[email protected]>
Co-authored-by: Harry Le <[email protected]>
Co-authored-by: Harry Le <[email protected]>
* fix: use copy instead of reference * fix: exclude swagger --------- Co-authored-by: sangjanai <[email protected]>
* test: add e2e files --------- Co-authored-by: Harry Le <[email protected]>
* test: check on ci * test: check all in ci * test: fix * test: fix 2 * test: fix 3 --------- Co-authored-by: Harry Le <[email protected]>
chore: add .vs to .gitignore to exclude Visual Studio files
* chore: suppress warnings on Windows * chore: msvc * chore: remove c-style cast
Co-authored-by: vansangpfiev <[email protected]>
* chore: resolve warnings, handle nodiscard, and add error logging * Update command_executor.h use macro PCLOSE to correctly map to _pclose on windows * fix typo: revert PCLOSE to _pclose for windows The PCLOSE macro was mistakenly defined as pclose for Windows. This commit fixes the typo, reverting it back to _pclose * chore: fix formatting --------- Co-authored-by: vansangpfiev <[email protected]>
fix: Exception Handling and multiline comment
Co-authored-by: Harry Le <[email protected]>
Co-authored-by: sangjanai <[email protected]>
fix: update career url
Co-authored-by: sangjanai <[email protected]>
Co-authored-by: vansangpfiev <[email protected]>
chore: sync main to dev
* remove python engine * remove docs * remove old methods * remove CI * remove model config * remove finetuning and some docs update * remove finetuning
* fix: crash if invalid url is set * fix: validation for hf --------- Co-authored-by: sangjanai <[email protected]>
* chore: Move to C++17 and fix extra warnings * Use maybe_unused attribute * curl_utils: Use unsigned to make msvc happy * Fix list init in macos code * Use unsigned in gguf_parser * fix list initialization again * use unsigned in cli_selection_utils.h * fix formatting * CMakeLists: Indicate to ensure we use c++17 * fix unit tests
fix: github url
Co-authored-by: sangjanai <[email protected]>
* epic: Add compiler optimizations * Remove -march=native flag
Co-authored-by: Akarshan Biswas <[email protected]>
chore: replace homebrew attr to menlo research
ci: add cortex docs new release
…to s/chore/sync-main
chore: sync main to dev
* fix: handle options preflight * fix: better handler * fix: better comparision for two url paths --------- Co-authored-by: sangjanai <[email protected]>
) Co-authored-by: sangjanai <[email protected]>
hiento09
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preview URL: https://ed39b93e.cortex-docs.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist