-
Notifications
You must be signed in to change notification settings - Fork 7
Katanagraph Plugin #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Katanagraph Plugin #213
Conversation
Hi, thanks for the plugin contribution! As you are working on this, I had a few questions:
|
Thanks for your response to the draft PR. It is still WIP.
They are identical. I am repackaging this, hoping to get katanagraph plugin merged to the metagraph core so that it can be reachable to all metagraph users. Any assistance would be appreciated! |
- katanagraph/label/dev::katana-cpp | ||
- katanagraph/label/dev::katana-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably actually release something before becoming a dependency of an external project. ;-) @wkyu2kg maybe talk to the release people to see if we should tag a release in the open package repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point. I also found katanagraph/label/dev is a bit inconsistent from other channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roshandathathri and @tylershunt Arthur suggested to have a release of katana-cpp and katana-python in the conda repo for them to be the dependency of metagraph plugin. How do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections but please start a discussion on slack. This may need inputs from many people including Rayees and approval from Chris/Barry.
First, I'm excited for other libraries to add plugins for metagraph! Without that, metagraph won't succeed as a project. Second, I don't think this should live in the metagraph repo directly. We could certainly add it as a new project under the "metagraph-dev" org. The benefits are:
As for making it easily findable by metagraph users, we have a place in the docs where we list community plugins. We should definitely add the Katanagraph plugin to that list. Also, we should look at other ways to make plugin discovery easier. I'm open to ideas. The one area we should look at including in metagraph core is any new abstract types or abstract algorithms that we expect to be used across plugins. Bringing those into the base will likely make things easier by avoiding plugin dependency issues. |
Thanks for the suggestions. This draft PR did help us to find ways to improve our plugin implementation, which still needs some work. We will discuss your recommendation internally and seek your help when ready. |
A draft PR for review.