Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

wkyu2kg
Copy link

@wkyu2kg wkyu2kg commented Jan 19, 2022

A draft PR for review.

@seibert
Copy link
Contributor

seibert commented Jan 19, 2022

Hi, thanks for the plugin contribution!

As you are working on this, I had a few questions:

  • How does this code relate to the Metagraph plugin in the katanagraph source code?: https://github.com/KatanaGraph/katana/tree/master/metagraph-plugin

  • Does this plugin need to be inside the Metagraph core package, or could we package it into a separate repository? The main advantage would be easier tracking of plugin dependencies (like which KatanaGraph versions are supported) as well as the ability to release plugin updates independent of the metagraph core itself.

@wkyu2kg
Copy link
Author

wkyu2kg commented Jan 19, 2022

Thanks for your response to the draft PR. It is still WIP.

* How does this code relate to the Metagraph plugin in the katanagraph source code?: https://github.com/KatanaGraph/katana/tree/master/metagraph-plugin

They are identical. I am repackaging this, hoping to get katanagraph plugin merged to the metagraph core so that it can be reachable to all metagraph users.

Any assistance would be appreciated!

Comment on lines +35 to +36
- katanagraph/label/dev::katana-cpp
- katanagraph/label/dev::katana-python
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably actually release something before becoming a dependency of an external project. ;-) @wkyu2kg maybe talk to the release people to see if we should tag a release in the open package repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point. I also found katanagraph/label/dev is a bit inconsistent from other channels.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roshandathathri and @tylershunt Arthur suggested to have a release of katana-cpp and katana-python in the conda repo for them to be the dependency of metagraph plugin. How do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections but please start a discussion on slack. This may need inputs from many people including Rayees and approval from Chris/Barry.

@jim22k
Copy link
Contributor

jim22k commented Jan 21, 2022

First, I'm excited for other libraries to add plugins for metagraph! Without that, metagraph won't succeed as a project.

Second, I don't think this should live in the metagraph repo directly. We could certainly add it as a new project under the "metagraph-dev" org. The benefits are:

  • Allow for different release schedule than metagraph core
  • Allow for different commit access between the katanagraph plugin and metagraph core

As for making it easily findable by metagraph users, we have a place in the docs where we list community plugins. We should definitely add the Katanagraph plugin to that list. Also, we should look at other ways to make plugin discovery easier. I'm open to ideas.

The one area we should look at including in metagraph core is any new abstract types or abstract algorithms that we expect to be used across plugins. Bringing those into the base will likely make things easier by avoiding plugin dependency issues.

@wkyu2kg
Copy link
Author

wkyu2kg commented Jan 25, 2022

Thanks for the suggestions. This draft PR did help us to find ways to improve our plugin implementation, which still needs some work. We will discuss your recommendation internally and seek your help when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants