YulStack: Use util::unreachable() instead of returning unnecessary values.

cameel · cameel · commit ee839e9a0eee · 2024-07-18T14:09:55.000+02:00
diff --git a/libyul/YulStack.cpp b/libyul/YulStack.cpp
@@ -44,6 +44,7 @@ using namespace solidity;
 using namespace solidity::frontend;
 using namespace solidity::yul;
 using namespace solidity::langutil;
+using namespace solidity::util;
 
 namespace
 {
@@ -257,8 +258,7 @@ MachineAssemblyObject YulStack::assemble(Machine _machine)
 	case Machine::EVM:
 		return assembleWithDeployed().first;
 	}
-	// unreachable
-	return MachineAssemblyObject();
+	unreachable();
 }
 
 std::pair<MachineAssemblyObject, MachineAssemblyObject>

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ using namespace solidity;`
`44`	`44`	`using namespace solidity::frontend;`
`45`	`45`	`using namespace solidity::yul;`
`46`	`46`	`using namespace solidity::langutil;`
	`47`	`+using namespace solidity::util;`
`47`	`48`
`48`	`49`	`namespace`
`49`	`50`	`{`
`@@ -257,8 +258,7 @@ MachineAssemblyObject YulStack::assemble(Machine _machine)`
`257`	`258`	`case Machine::EVM:`
`258`	`259`	`return assembleWithDeployed().first;`
`259`	`260`	`}`
`260`		`- // unreachable`
`261`		`- return MachineAssemblyObject();`
	`261`	`+ unreachable();`
`262`	`262`	`}`
`263`	`263`
`264`	`264`	`std::pair<MachineAssemblyObject, MachineAssemblyObject>`