fix: dont log error if notify panics

christos-h · web-flow · commit 3df5d10e3375 · 2021-09-17T17:08:21.000+01:00
diff --git a/synth/src/main.rs b/synth/src/main.rs
@@ -11,7 +11,7 @@ async fn main() -> Result<()> {
     let args = Args::from_args();
     let cli = Cli::new()?;
 
-    let notify_handle = thread::spawn(|| synth::version::notify_new_version_message().unwrap());
+    let notify_handle = thread::spawn(synth::version::notify_new_version_message);
 
     #[cfg(feature = "telemetry")]
     synth::cli::telemetry::with_telemetry(args, |args| cli.run(args)).await?;
@@ -24,8 +24,8 @@ async fn main() -> Result<()> {
     Ok(())
 }
 
-fn print_notify(handle: JoinHandle<Option<String>>) {
-    if let Some(notify_message) = handle.join().unwrap_or_default() {
+fn print_notify(handle: JoinHandle<Result<Option<String>>>) {
+    if let Ok(Ok(Some(notify_message))) = handle.join() {
         eprintln!("{}", notify_message);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ async fn main() -> Result<()> {`
`11`	`11`	`let args = Args::from_args();`
`12`	`12`	`let cli = Cli::new()?;`
`13`	`13`
`14`		`- let notify_handle = thread::spawn(\|\| synth::version::notify_new_version_message().unwrap());`
	`14`	`+ let notify_handle = thread::spawn(synth::version::notify_new_version_message);`
`15`	`15`
`16`	`16`	`#[cfg(feature = "telemetry")]`
`17`	`17`	`synth::cli::telemetry::with_telemetry(args, \|args\| cli.run(args)).await?;`
`@@ -24,8 +24,8 @@ async fn main() -> Result<()> {`
`24`	`24`	`Ok(())`
`25`	`25`	`}`
`26`	`26`
`27`		`-fn print_notify(handle: JoinHandle<Option<String>>) {`
`28`		`- if let Some(notify_message) = handle.join().unwrap_or_default() {`
	`27`	`+fn print_notify(handle: JoinHandle<Result<Option<String>>>) {`
	`28`	`+ if let Ok(Ok(Some(notify_message))) = handle.join() {`
`29`	`29`	`eprintln!("{}", notify_message);`
`30`	`30`	`}`
`31`	`31`	`}`