rp2/machine_rtc: Check return value from rtc_set_alarm.

kadamski · kadamski · commit 157f9a90f70b · 2021-06-13T21:42:05.000+02:00
The rtc_set_datetime() from pico-sdk will validate the values in the datetime_t structure and refuse to set the time if they aren't valid. It makes sense to raise an exception if this happens instead of failing silently which might be confusing (as an example, see: #6928 (comment) ).
diff --git a/lib/mbedtls b/lib/mbedtls
@@ -1 +1 @@
-Subproject commit 1bc2c9cb8b8fe4659bd94b8ebba5a4c02029b7fa
+Subproject commit 1b6a24f759cefbb4a69ae9476885d7f42a847e3d
diff --git a/ports/rp2/machine_rtc.c b/ports/rp2/machine_rtc.c
@@ -100,7 +100,9 @@ STATIC mp_obj_t machine_rtc_datetime(mp_uint_t n_args, const mp_obj_t *args) {
             .sec = mp_obj_get_int(items[6]),
         };
 
-        rtc_set_datetime(&t);
+        if (!rtc_set_datetime(&t)) {
+            mp_raise_OSError(MP_EINVAL);
+        }
 
     }
     return mp_const_none;

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,9 @@ STATIC mp_obj_t machine_rtc_datetime(mp_uint_t n_args, const mp_obj_t *args) {`
`100`	`100`	`.sec = mp_obj_get_int(items[6]),`
`101`	`101`	`};`
`102`	`102`
`103`		`- rtc_set_datetime(&t);`
	`103`	`+ if (!rtc_set_datetime(&t)) {`
	`104`	`+ mp_raise_OSError(MP_EINVAL);`
	`105`	`+ }`
`104`	`106`
`105`	`107`	`}`
`106`	`108`	`return mp_const_none;`