use IsReferenceOrContainsReferences for .NET Standard 2.1+ and 6_0+#901
Merged
badrishc merged 1 commit intomicrosoft:mainfrom Mar 24, 2024
Merged
use IsReferenceOrContainsReferences for .NET Standard 2.1+ and 6_0+#901badrishc merged 1 commit intomicrosoft:mainfrom
badrishc merged 1 commit intomicrosoft:mainfrom
Conversation
badrishc
approved these changes
Mar 24, 2024
|
Deleted earlier incorrect comment, misread the changes 🤦♂️ This actually fixes a bug as the .NET 7+ onwards it is invalid to rely on dummy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the change done by @PaulusParssinen done in microsoft/garnet#36 to FASTER.
This only applies to the builds for .NET STANDARD 2.1 and 6_0+ as otherwise the helper method is not available, the reflection method is also still used in the code.