Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<memory>: ~_Ref_count_base() should be non-virtual #208

@StephanTLavavej

Description

@StephanTLavavej

virtual ~_Ref_count_base() noexcept {} // TRANSITION, should be non-virtual

shared_ptr's type-erasure machinery doesn't require the reference count control block to have a virtual destructor. Making this non-virtual would be a minor improvement, but it's an ABI-breaking change.

vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSomething can be improvedvNextBreaks binary compatibility

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions