-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
enhancementSomething can be improvedSomething can be improvedvNextBreaks binary compatibilityBreaks binary compatibility
Description
Line 620 in 6b0238d
| virtual ~_Ref_count_base() noexcept {} // TRANSITION, should be non-virtual |
shared_ptr's type-erasure machinery doesn't require the reference count control block to have a virtual destructor. Making this non-virtual would be a minor improvement, but it's an ABI-breaking change.
vNext note: Resolving this issue will require breaking binary compatibility. We won't be able to accept pull requests for this issue until the vNext branch is available. See #169 for more information.
Metadata
Metadata
Assignees
Labels
enhancementSomething can be improvedSomething can be improvedvNextBreaks binary compatibilityBreaks binary compatibility