Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unwanted constant comparisons potentially causing bugs #61654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
ulrichstark opened this issue May 4, 2025 · 0 comments · May be fixed by #61655
Open
1 task done

Unwanted constant comparisons potentially causing bugs #61654

ulrichstark opened this issue May 4, 2025 · 0 comments · May be fixed by #61655
Labels
Bug A bug in TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@ulrichstark
Copy link

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

I was running npx oxlint src -A all -D const-comparisons to test oxlint and unintentionally discovered some unwanted constant comparisons potentially causing bugs:

TypeScript/src/compiler/resolutionCache.ts

Line 327 in d88d3a4

if (fileOrDirComponents.length < fileOrDirComponents.length) return false;

TypeScript/src/harness/fourslashImpl.ts

Line 2603 in d88d3a4

: (q1.marker.fileName > q1.marker.fileName ? 1 : -1)

Both conditions will always be false.
@ulrichstark ulrichstark linked a pull request May 4, 2025 that will close this issue
Open
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this labels May 6, 2025
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix unwanted constant comparisons potentially causing bugs ulrichstark/TypeScript
2 participants
@RyanCavanaugh @ulrichstark