Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 35d6148

Browse files
travkin79travkin79
committed
Incorporate Copilot improvement suggestions
1 parent 54b5ce0 commit 35d6148

15 files changed

Lines changed: 101 additions & 93 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ The installable P2 repository is generated in `com.microsoft.copilot.eclipse.rep
5858
* Select *File > Import... > General > Existing projects into Workspace*,
5959
select the root directory of the copilot-for-eclipse git repo,
6060
activate the check box *Search for nested projects*, and finish the wizard.
61-
* Do also import the agent bundle for your OS (e.g., `com.microsoft.copilot.eclipse.core.agent.win-x64`)
61+
* Do also import the agent bundle for your OS (e.g., `com.microsoft.copilot.eclipse.core.agent.win32`)
6262
after building the project with npm and maven or import all OS-specific agent bundles.
6363
2. Activate one of the target platforms, i.e. open one of the target definition files and select `Set As Active Target Platform`.
6464
* target-terminal.target (Eclipse 4.37+)
@@ -69,7 +69,7 @@ The installable P2 repository is generated in `com.microsoft.copilot.eclipse.rep
6969
* Select Type="Project Relative Configuration", **name="copilot4eclipse"**, and choose the location using the *Browse...* button.
7070
The `checkstyle.xml` file is in the git repository root folder in the project "github-copilot-for-eclipse".
7171
4. Use the launch configurations in the `launch/` directory, e.g. for launching a new Eclipse IDE with Copilot plug-ins.
72-
* Check the selected plug-ins in your launch configuration (in *Plug-ins* tab)and remove any OS-specific agent bundle that does not fit
72+
* Check the selected plug-ins in your launch configuration (in *Plug-ins* tab) and remove any OS-specific agent bundle that does not fit
7373
to your OS and remove all test bundles from the selected plug-ins from your Eclipse workspace.
7474
* Validate your config and ensure that all dependencies are resolved.
7575
Try *Select Required* button if something is missing.

‎com.microsoft.copilot.eclipse.branding/.classpath‎

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<classpath>
3-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
4-
<attributes>
5-
<attribute name="maven.pomderived" value="true"/>
6-
</attributes>
7-
</classpathentry>
8-
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
9-
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
10-
<attributes>
11-
<attribute name="maven.pomderived" value="true"/>
12-
</attributes>
13-
</classpathentry>
14-
<classpathentry kind="output" path="target/classes"/>
15-
</classpath>
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<classpath>
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
4+
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
5+
<classpathentry kind="output" path="target/classes"/>
6+
</classpath>

‎com.microsoft.copilot.eclipse.branding/.project‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,16 @@
2525
<arguments>
2626
</arguments>
2727
</buildCommand>
28+
<buildCommand>
29+
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
30+
<arguments>
31+
</arguments>
32+
</buildCommand>
2833
</buildSpec>
2934
<natures>
30-
<nature>org.eclipse.jdt.core.javanature</nature>
31-
<nature>org.eclipse.pde.PluginNature</nature>
3235
<nature>org.eclipse.m2e.core.maven2Nature</nature>
36+
<nature>org.eclipse.pde.PluginNature</nature>
37+
<nature>org.eclipse.jdt.core.javanature</nature>
38+
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
3339
</natures>
3440
</projectDescription>

‎com.microsoft.copilot.eclipse.core.agent.linux.aarch64/.classpath‎

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<classpath>
3-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
4-
<attributes>
5-
<attribute name="maven.pomderived" value="true"/>
6-
</attributes>
7-
</classpathentry>
8-
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
9-
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
10-
<attributes>
11-
<attribute name="maven.pomderived" value="true"/>
12-
</attributes>
13-
</classpathentry>
14-
<classpathentry kind="output" path="target/classes"/>
15-
</classpath>
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<classpath>
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
4+
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
5+
<classpathentry kind="src" path="src"/>
6+
<classpathentry kind="output" path="target/classes"/>
7+
</classpath>

‎com.microsoft.copilot.eclipse.core.agent.linux.aarch64/.project‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,16 @@
2525
<arguments>
2626
</arguments>
2727
</buildCommand>
28+
<buildCommand>
29+
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
30+
<arguments>
31+
</arguments>
32+
</buildCommand>
2833
</buildSpec>
2934
<natures>
3035
<nature>org.eclipse.jdt.core.javanature</nature>
3136
<nature>org.eclipse.pde.PluginNature</nature>
3237
<nature>org.eclipse.m2e.core.maven2Nature</nature>
38+
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
3339
</natures>
3440
</projectDescription>

‎com.microsoft.copilot.eclipse.core.agent.linux.x64/.classpath‎

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<classpath>
3-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
4-
<attributes>
5-
<attribute name="maven.pomderived" value="true"/>
6-
</attributes>
7-
</classpathentry>
8-
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
9-
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
10-
<attributes>
11-
<attribute name="maven.pomderived" value="true"/>
12-
</attributes>
13-
</classpathentry>
14-
<classpathentry kind="output" path="target/classes"/>
15-
</classpath>
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<classpath>
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
4+
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
5+
<classpathentry kind="src" path="src"/>
6+
<classpathentry kind="output" path="target/classes"/>
7+
</classpath>

‎com.microsoft.copilot.eclipse.core.agent.linux.x64/.project‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,16 @@
2525
<arguments>
2626
</arguments>
2727
</buildCommand>
28+
<buildCommand>
29+
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
30+
<arguments>
31+
</arguments>
32+
</buildCommand>
2833
</buildSpec>
2934
<natures>
30-
<nature>org.eclipse.jdt.core.javanature</nature>
31-
<nature>org.eclipse.pde.PluginNature</nature>
3235
<nature>org.eclipse.m2e.core.maven2Nature</nature>
36+
<nature>org.eclipse.pde.PluginNature</nature>
37+
<nature>org.eclipse.jdt.core.javanature</nature>
38+
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
3339
</natures>
3440
</projectDescription>

‎com.microsoft.copilot.eclipse.core.agent.macosx.aarch64/.classpath‎

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<classpath>
3-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
4-
<attributes>
5-
<attribute name="maven.pomderived" value="true"/>
6-
</attributes>
7-
</classpathentry>
8-
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
9-
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
10-
<attributes>
11-
<attribute name="maven.pomderived" value="true"/>
12-
</attributes>
13-
</classpathentry>
14-
<classpathentry kind="output" path="target/classes"/>
15-
</classpath>
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<classpath>
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
4+
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
5+
<classpathentry kind="src" path="src"/>
6+
<classpathentry kind="output" path="target/classes"/>
7+
</classpath>

‎com.microsoft.copilot.eclipse.core.agent.macosx.aarch64/.project‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,16 @@
2525
<arguments>
2626
</arguments>
2727
</buildCommand>
28+
<buildCommand>
29+
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
30+
<arguments>
31+
</arguments>
32+
</buildCommand>
2833
</buildSpec>
2934
<natures>
30-
<nature>org.eclipse.jdt.core.javanature</nature>
31-
<nature>org.eclipse.pde.PluginNature</nature>
3235
<nature>org.eclipse.m2e.core.maven2Nature</nature>
36+
<nature>org.eclipse.pde.PluginNature</nature>
37+
<nature>org.eclipse.jdt.core.javanature</nature>
38+
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
3339
</natures>
3440
</projectDescription>

‎com.microsoft.copilot.eclipse.core.agent.macosx.x64/.classpath‎

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
1-
<?xml version="1.0" encoding="UTF-8"?>
2-
<classpath>
3-
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
4-
<attributes>
5-
<attribute name="maven.pomderived" value="true"/>
6-
</attributes>
7-
</classpathentry>
8-
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
9-
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
10-
<attributes>
11-
<attribute name="maven.pomderived" value="true"/>
12-
</attributes>
13-
</classpathentry>
14-
<classpathentry kind="output" path="target/classes"/>
15-
</classpath>
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<classpath>
3+
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
4+
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
5+
<classpathentry kind="src" path="src"/>
6+
<classpathentry kind="output" path="target/classes"/>
7+
</classpath>

0 commit comments

Comments
 (0)