Add tests for virtualenvwrapper, pyenv-virtuaenv, conda and a fixes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 6, 2024
| @@ -117,6 +117,10 @@ pub fn get_environments(conda_dir: &Path) -> Vec<PathBuf> { | |||
| .collect(), | |||
| ); | |||
| } | |||
| // Then read the .condarc in the conda install folder as well. | |||
| if let Some(mut conda_rc) = Condarc::from_path(conda_dir) { | |||
There was a problem hiding this comment.
Missed this earlier
DonJayamanne
commented
Jun 6, 2024
| } | ||
|
|
||
| /// Find the conda binary on the system | ||
| pub fn find_conda_binary(env_vars: &EnvVariables) -> Option<PathBuf> { |
There was a problem hiding this comment.
Not required (old code)
DonJayamanne
commented
Jun 6, 2024
| if let Some(filename) = &env.prefix { | ||
| name = filename.to_str().map(|f| f.to_string()); | ||
| if let Some(prefix) = &env.prefix { | ||
| if let Some(filename) = prefix.file_name() { |
DonJayamanne
commented
Jun 6, 2024
| .into_values() | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| assert!( |
There was a problem hiding this comment.
more tests, and fixed issues found while adding this test
DonJayamanne
commented
Jun 6, 2024
|
|
||
| assert!( | ||
| environments.iter().any( | ||
| |env| env.category == PythonEnvironmentCategory::PyenvVirtualEnv |
There was a problem hiding this comment.
more tests, and fixed issues found while adding this test
DonJayamanne
commented
Jun 6, 2024
| let program_data = env_vars.programdata.clone().unwrap_or_default(); | ||
| let all_user_profile = env_vars.allusersprofile.clone().unwrap_or_default(); | ||
| let home_drive = env_vars.homedrive.clone().unwrap_or_default(); | ||
| let mut known_paths = vec![ |
There was a problem hiding this comment.
unnecessary, duplicate code removed
karthiknadig
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of fixes/tweeks as a result of the tests finding issues.