Incremental reporting of Conda envs #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 7, 2024
| @@ -39,5 +40,5 @@ pub trait Locator: Send + Sync { | |||
| /** | |||
| * Finds all environments specific to this locator. | |||
| */ | |||
| fn find(&self) -> Option<LocatorResult>; | |||
| fn find(&self, reporter: &dyn Reporter); | |||
There was a problem hiding this comment.
Previously we'd report as soon as each locator finds environments.
Thats very fast.
However I can see conda getting slower and slower.
E.g. everything completes in < 50ms for me, except for conda.
Now that I have installed 30 conda envs, and 8 conda installs, it takes 100-200ms
So, first conda gets reported only after all conda envs have been disccovered.
The change is to now report immediately as they are discovered.
Perf is still the same, perhaps slightly faster,
DonJayamanne
commented
Jun 7, 2024
| let env = env.to_python_environment(None, None); | ||
| let mut environments = self.environments.lock().unwrap(); | ||
| environments.insert(prefix, env.clone()); | ||
| reporter.report_environment(&env); |
There was a problem hiding this comment.
as soon as we discover anything we report it.
Previously we-d collect and return to calling code.
karthiknadig
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.