From bede67d47a89126402583ddfc7dfa7f8f30691a0 Mon Sep 17 00:00:00 2001 From: Cameron Trando Date: Thu, 25 Jul 2019 13:26:38 -0700 Subject: [PATCH] Changing error to warning --- .../Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs | 4 ++-- src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs | 2 +- .../Impl/Specializations/Typing/Types/GenericTypeParameter.cs | 2 +- src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs | 2 +- src/Analysis/Ast/Test/LintNoQATests.cs | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs b/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs index 514d1e735..6e3f8273c 100644 --- a/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs +++ b/src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.Generics.cs @@ -72,7 +72,7 @@ private bool GenericClassParameterValid(IReadOnlyList ge Resources.GenericNotAllTypeParameters, GetLocation(expr).Span, ErrorCodes.TypingGenericArguments, - Severity.Error, + Severity.Warning, DiagnosticSource.Analysis)); return false; } @@ -83,7 +83,7 @@ private bool GenericClassParameterValid(IReadOnlyList ge Resources.GenericNotAllUnique, GetLocation(expr).Span, ErrorCodes.TypingGenericArguments, - Severity.Error, + Severity.Warning, DiagnosticSource.Analysis)); return false; } diff --git a/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs b/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs index 2b31720c4..d6103af7d 100644 --- a/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs +++ b/src/Analysis/Ast/Impl/Analyzer/Symbols/ClassEvaluator.cs @@ -202,7 +202,7 @@ private void ReportInvalidBase(string argVal) { Resources.InheritNonClass.FormatInvariant(argVal), _classDef.NameExpression.GetLocation(Eval)?.Span ?? default, Diagnostics.ErrorCodes.InheritNonClass, - Severity.Error, + Severity.Warning, DiagnosticSource.Analysis )); } diff --git a/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs b/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs index d2570dba6..5c416f2a1 100644 --- a/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs +++ b/src/Analysis/Ast/Impl/Specializations/Typing/Types/GenericTypeParameter.cs @@ -69,7 +69,7 @@ private static bool TypeVarArgumentsValid(IArgumentSet argSet) { new DiagnosticsEntry(Resources.TypeVarSingleConstraint, callLocation?.Span ?? default, Diagnostics.ErrorCodes.TypingTypeVarArguments, - Severity.Error, DiagnosticSource.Analysis) + Severity.Warning, DiagnosticSource.Analysis) ); return false; } diff --git a/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs b/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs index 6b980b2d6..9964e3d66 100644 --- a/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs +++ b/src/Analysis/Ast/Impl/Specializations/Typing/TypingModule.cs @@ -244,7 +244,7 @@ private IPythonType CreateTypeAlias(IArgumentSet args) { new DiagnosticsEntry(Resources.NewTypeFirstArgNotString.FormatInvariant(firstArgType), expression?.GetLocation(eval)?.Span ?? default, Diagnostics.ErrorCodes.TypingNewTypeArguments, - Severity.Error, DiagnosticSource.Analysis) + Severity.Warning, DiagnosticSource.Analysis) ); } // TODO: report wrong number of arguments diff --git a/src/Analysis/Ast/Test/LintNoQATests.cs b/src/Analysis/Ast/Test/LintNoQATests.cs index 9de8a4d18..172f0bbdc 100644 --- a/src/Analysis/Ast/Test/LintNoQATests.cs +++ b/src/Analysis/Ast/Test/LintNoQATests.cs @@ -90,7 +90,7 @@ public async Task VarNamedNoQAStillGivesDiagnostic() { diagnostic.Message.Should().Be(Resources.GenericNotAllUnique); diagnostic.ErrorCode.Should().Be(ErrorCodes.TypingGenericArguments); diagnostic.SourceSpan.Should().Be(8, 8, 8, 21); - diagnostic.Severity.Should().Be(Severity.Error); + diagnostic.Severity.Should().Be(Severity.Warning); } [DataRow("x = y #noqa")]