Codestin Search App

anthonykim1 · 2026-04-23T17:13:25Z

Resolves: #309290

Still very much in progress.
Please see comments below (videos, screenshot, comments)
Feel free to fetch this branch locally and play around.

Both route with/without controller api should work.

Co-authored-by: Copilot <[email protected]>

…chatPanel

Copilot

Pull request overview

This PR introduces a proposed chat sessions API for extensions to inject system-initiated “notification-style” turns into chat sessions they own, and wires it up for Copilot CLI sessions so async SDK/terminal completions can surface as new chat bubbles.

Changes:

Add vscode.chat.sendSystemInitiatedRequest(...) proposed API + options type.
Implement ext host ↔ main thread plumbing to enqueue a steering, system-initiated chat request with a label.
Update Copilot CLI chat sessions to forward SDK system.notification events into the chat panel and keep SDK sessions alive long enough for async completions to arrive.

Show a summary per file

File	Description
src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts	Adds proposed API surface for system-initiated chat requests.
src/vs/workbench/api/common/extHostChatSessions.ts	Validates ownership + forwards requests to main thread via RPC.
src/vs/workbench/api/common/extHost.protocol.ts	Extends main-thread chat sessions shape with `$sendSystemInitiatedRequest`.
src/vs/workbench/api/common/extHost.api.impl.ts	Exposes `chat.sendSystemInitiatedRequest` to extensions under proposed API gate.
src/vs/workbench/api/browser/mainThreadChatSessions.ts	Receives RPC and enqueues a steering system-initiated request in `IChatService`.
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts	Forwards CLI SDK system notifications into chat via the new API; passes through `isSystemInitiated`.
extensions/copilot/src/extension/chatSessions/copilotcli/node/test/testHelpers.ts	Updates mock SDK session helper with an `on(...)` method to match usage.
extensions/copilot/src/extension/chatSessions/copilotcli/node/test/copilotcliSession.spec.ts	Extends test mock with `getBackgroundTasks()` to satisfy new logging/inspection.
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts	Emits `onDidReceiveSystemNotification` and adds a post-turn keep-alive ref window.
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSession.ts	Translates SDK `system.notification` to a typed event; adds system-initiated request handling path.

Copilot's findings

Comments suppressed due to low confidence (1)

extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSession.ts:357

There is new behavior for request.isSystemInitiated that changes how requests are handled (skipping _sdkSession.send() and waiting for the next assistant.turn_end). The existing unit tests for CopilotCLISession don't cover the isSystemInitiated path; please add a test that asserts the SDK send() is not called and that the handler resolves on assistant.turn_end / cancellation.

			}

			if (isAlreadyBusyWithAnotherRequest) {
				return this._handleRequestSteering(input, attachments, model, previousRequestSnapshot, token);
			} else {
				return this._handleRequestImpl(request, input, attachments, model, token, /*isSystemInitiated*/ false);
			}
		});

Files reviewed: 9/10 changed files
Comments generated: 5

anthonykim1 · 2026-04-23T19:54:57Z

@DonJayamanne @rebornix @mattbierner

Don't think activeResponseCallback in

vscode/src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts

Lines 446 to 453 in ad4cb84

    
           		/** 
        
           		 * Callback invoked by the editor for a currently running response. This allows the session to push items for the 
        
           		 * current response and stream these in as them come in. The current response will be considered complete once the 
        
           		 * callback resolved. 
        
           		 * 
        
           		 * If not provided, the chat session is assumed to not currently be running. 
        
           		 */ 
        
           		readonly activeResponseCallback?: (stream: ChatResponseStream, token: CancellationToken) => Thenable<void>;

would do it since it would show the progress shimmer that the response is still in progress?

I think the biggest thing against activateResponseCallback is that ui would be stuck in perpetual shimmer/responding state with all notification glued onto the previous assistant turn as if the model never stopped talking, and user wouldn't be able to send follow ups without killing the very thing that delivers the notification.

VS.

(This PR with new proposed api):

The approach from the PR we'd have no stalling shimmer, but would have new compact "system" bubble appear for async output such as sleep 5 finished

Also user can type follow up anytime (input not blocked).
Multiple async shell should work via multiple discrete bubble (clearly its own event).

Co-authored-by: Copilot <[email protected]>

…path Co-authored-by: Copilot <[email protected]>

anthonykim1 · 2026-04-23T21:25:40Z

@roblourens @TylerLeonhardt
Here is what it would look like as of Apr 23rd, 2:23 p.m. PST:

Screen.Recording.2026-04-23.at.2.22.09.PM.mov

Here is equivalent in Copilot CLI.

We could improve to better distinguish the async terminal output but it seems like CLI themselves are not doing explicit labeling either. Maybe the color of the decorations are meant to signify something?

/cc @justschen For chat ui

Co-authored-by: Copilot <[email protected]>

anthonykim1 · 2026-04-23T21:33:28Z

+		// task list only includes *detached* shells and background agents, not
+		// plain `mode: "async"` shells (they're tracked internally by
+		// `shellContext.currentExecutions`). A status-based window matches the
+		// existing `sessionTerminators` 5-minute lifetime and covers every


@DonJayamanne @roblourens I'm not so sure about this 5-minute lifetime thing. I can see it was existing previously but don't have context over what specific thing it was meant for, maybe we can do something better here for async terminals and keeping session alive.

github-actions · 2026-04-23T21:34:49Z

Screenshot Changes

Base: 5f818f4c Current: 42506f1e

Changed (1)

sessions/sessionsPolicyBlocked/Loading/Light

Before	After

Co-authored-by: Copilot <[email protected]>

anthonykim1 · 2026-04-23T21:39:10Z

 		this.sessionId = _sdkSession.sessionId;
 		this.add(toDisposable(() => this._todoSqlQuery.dispose()));
+
+		// Forward SDK system notifications (async/detached shell completions,


I'll probably delete this before final review but thought it would be helpful for earlier people who read, understand more carefully.

DonJayamanne · 2026-04-23T22:54:59Z

+		const disposables = new DisposableStore();
+		try {
+			await new Promise<void>(resolve => {
+				const off = this._sdkSession.on('assistant.turn_end', () => resolve());


what happens if the next turn also starts an async terminal call?

DonJayamanne · 2026-04-23T22:56:31Z

+			try {
+				const notification = this._buildSystemNotification(event);
+				if (notification) {
+					this._onDidReceiveSystemNotification.fire(notification);


What happens if the async terminal completes within the current turn?
I think with this approach we will always end up going out of there and sending a message to core and then re-enter as another request handler when it could've been handled in a single turn.

DonJayamanne · 2026-04-23T23:13:42Z

+		session.add(toDisposable(releaseKeepAlive));
+		session.add(session.onDidChangeStatus(() => {
+			const status = session.status;
+			if (session.permissionRequested) {


Please do not use permissionRequested, this will be removed.

DonJayamanne · 2026-04-23T23:16:04Z

+				keepAliveTimer.clear();
+				return;
+			}
+			if (status === undefined || status === ChatSessionStatus.Completed || status === ChatSessionStatus.Failed) {


Doesn't this mean that ALL sessions will always keep a ref to this object and never release it?

DonJayamanne · 2026-04-23T23:39:43Z

+		 * Rendered as a compact system-notification chip in the chat transcript
+		 * (e.g. ``"`sleep 10` completed"``).
+		 */
+		readonly systemInitiatedLabel: string;


perhaps prompt is a better property
If its a request thats being sent, then i would like to think the message thats sent as part of the request would be a prompt or command, & this case it should be a prompt.

anthonykim1 and others added 11 commits April 22, 2026 16:05

working changes to keep session title with panel and cli resume

5003151

Co-authored-by: Copilot <[email protected]>

allow syncing of session title from side bar and editor tab

701e10d

Co-authored-by: Copilot <[email protected]>

remove raceCanellation

372bb78

Co-authored-by: Copilot <[email protected]>

Stop using <T> for void

159d3e4

Co-authored-by: Copilot <[email protected]>

better name

0a1c2f5

Co-authored-by: Copilot <[email protected]>

stage title locally when SDK session isn't materialized yet

41c78e8

Co-authored-by: Copilot <[email protected]>

Merge branch 'main' into anthonykim1/updateCLIsessionTitle

0c44356

Merge branch 'main' into anthonykim1/updateCLIsessionTitle

b461750

rename to fix test

279b499

futher unify title resolution through single resolver

1ee441e

Co-authored-by: Copilot <[email protected]>

Support async terminal in cli chat panel

82c6dad

Co-authored-by: Copilot <[email protected]>

anthonykim1 self-assigned this Apr 23, 2026

Copilot AI review requested due to automatic review settings April 23, 2026 17:13

Merge branch 'main' into anthonykim1/supportAsyncTerminalInCopilotCLI…

58a13db

…chatPanel

Copilot started reviewing on behalf of anthonykim1 April 23, 2026 17:14 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

anthonykim1 and others added 3 commits April 23, 2026 13:00

stop using unknown in test

4971ba6

Co-authored-by: Copilot <[email protected]>

clean up anthony's comment

6576f4f

Co-authored-by: Copilot <[email protected]>

Wire system.notification listener for V1 (legacy) session controller …

f58b7fb

…path Co-authored-by: Copilot <[email protected]>

anthonykim1 and others added 2 commits April 23, 2026 14:29

try to clean up logs a bit

4c2390c

Co-authored-by: Copilot <[email protected]>

Try to fix test

81d17ee

anthonykim1 commented Apr 23, 2026

View reviewed changes

tighten the wording in proposed api

7dbe073

Co-authored-by: Copilot <[email protected]>

anthonykim1 commented Apr 23, 2026

View reviewed changes

DonJayamanne reviewed Apr 23, 2026

View reviewed changes

DonJayamanne requested a review from meganrogge April 23, 2026 23:41

Conversation

anthonykim1 commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anthonykim1 commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anthonykim1 commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anthonykim1 Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 23, 2026

Screenshot Changes

Changed (1)

Uh oh!

anthonykim1 Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

DonJayamanne Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anthonykim1 commented Apr 23, 2026 •

edited

Loading

anthonykim1 commented Apr 23, 2026 •

edited

Loading

anthonykim1 commented Apr 23, 2026 •

edited

Loading

anthonykim1 Apr 23, 2026 •

edited

Loading