Fixes as per code review comments

DonJayamanne · DonJayamanne · commit 5f8799fd9704 · 2020-03-12T16:01:17.000-07:00
diff --git a/news/2 Fixes/9403.md b/news/2 Fixes/9403.md
@@ -1 +1 @@
-If require, use a custom paper size when exporting plots to `PDF`
+Use a custom paper size when exporting plots to `PDF`
diff --git a/src/client/datascience/plotting/plotViewer.ts b/src/client/datascience/plotting/plotViewer.ts
@@ -169,15 +169,8 @@ export class PlotViewer extends WebViewHost<IPlotViewerMapping> implements IPlot
                         );
                         const options: Record<string, {}> = {};
                         if (dimensions && dimensions.width && dimensions.height) {
-                            const LetterSize = { width: 612, height: 792.0 }; //https://github.com/foliojs/pdfkit/blob/master/lib/page.js#L62
-                            // If the default LETTER size is smaller than image, then use a custom paper size.
-                            // This ensuresimages are not cropped.
-                            if (dimensions.width > LetterSize.width || dimensions.height > LetterSize.height) {
-                                options.size = [
-                                    Math.max(dimensions.width, LetterSize.width),
-                                    Math.max(dimensions.height, LetterSize.height)
-                                ];
-                            }
+                            // Ensure image fits, hence use our own size.
+                            options.size = [dimensions.width, dimensions.height];
                         }
                         const doc = new pdfkit(options);
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-If require, use a custom paper size when exporting plots to `PDF`
	`1`	+Use a custom paper size when exporting plots to `PDF`