Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make sure there's no await between clearing and filling the environment #24914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tyriar opened this issue Mar 18, 2025 · 5 comments · Fixed by #24921
Open

Make sure there's no await between clearing and filling the environment #24914

Tyriar opened this issue Mar 18, 2025 · 5 comments · Fixed by #24921
Assignees
@karthiknadig @eleanorjboyd
Labels
bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on. verification-found Issue verification failed
Milestone
May 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2025 •
edited
Loading

This is causing the warning icon to show up more.

vscode-python/src/client/terminals/envCollectionActivation/service.ts

Lines 224 to 226 in b4aa112

// Clear any previously set env vars from collection
envVarCollection.clear();
const deactivate = await this.terminalDeactivateService.getScriptLocation(shell, resource);

@Tyriar Tyriar added the feature-request Request for new features or functionality label Mar 18, 2025
@Tyriar Tyriar added this to the March 2025 milestone Mar 18, 2025
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 18, 2025
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Mar 18, 2025
@eleanorjboyd
Copy link
Member

looping in Karthik since the terminal environment items on the core python extension related to terminal deactivation is under his domain

@eleanorjboyd eleanorjboyd mentioned this issue Mar 19, 2025
Merged
@karthiknadig karthiknadig added the verification-steps-needed Steps to verify are needed for verification label Mar 25, 2025
@eleanorjboyd
Copy link
Member

after restart or update python asking to reload the terminal to add env var.
Image (reported by @jrieken)

steps:

  1. open vscode with python extension
  2. open terminal
  3. reload page
  4. check to make sure there is no suggestion to edit terminal env vars

@eleanorjboyd eleanorjboyd removed the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 27, 2025
@rzhao271
Copy link

I consistently see a suggestion to edit terminal env vars after reloading the editor.
This is with a Python file open with a venv set up in the workspace.

@rzhao271 rzhao271 reopened this Mar 27, 2025
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Mar 27, 2025
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 27, 2025
@karthiknadig karthiknadig modified the milestones: March 2025, April 2025 Mar 27, 2025
@karthiknadig karthiknadig self-assigned this Mar 27, 2025
@eleanorjboyd
Copy link
Member

@rzhao271, when you get a chance could you print out your path variable before and after reloading and send it to me? Something is changing there which @karthiknadig could repro with fnm but I am struggling to do so with my current setup.

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Mar 28, 2025
@github-actions GitHub Actions
Copy link

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off.

Happy Coding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2025
@karthiknadig karthiknadig reopened this Apr 27, 2025
@karthiknadig karthiknadig added needs spike Label for issues that need investigation before they can be worked on. and removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Apr 27, 2025
@eleanorjboyd eleanorjboyd modified the milestones: April 2025, May 2025 Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthiknadig karthiknadig

@eleanorjboyd eleanorjboyd

Labels
bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on. verification-found Issue verification failed
Projects
None yet
Milestone
May 2025
Development

Successfully merging a pull request may close this issue.

move clear envCollection to after await eleanorjboyd/vscode-python
4 participants
@Tyriar @karthiknadig @rzhao271 @eleanorjboyd