Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Force package.json and package-lock.json to end in LF #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue Dec 5, 2017 · 0 comments · Fixed by #357
Closed

Force package.json and package-lock.json to end in LF #355

brettcannon opened this issue Dec 5, 2017 · 0 comments · Fixed by #357
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

As reported in npm/npm#17161, npm rewrites both package.json and package-lock.json to have LF line endings. That sucks when you have autocrlf=auto turned on for git.

Basically we need to add a .gitattributes file with the following to make it so running npm on Windows doesn't constantly leading to git thinking there are file changes to commit:

package.json text eol=lf
package-lock.json text eol=lf
@brettcannon brettcannon added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 5, 2017
@brettcannon brettcannon self-assigned this Dec 5, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant