Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove picker focus when using selectUsersById #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix: remove picker focus when using selectUsersById #3282

merged 3 commits into from
Sep 3, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Sep 3, 2024 •
edited
Loading

Closes #3184

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner September 3, 2024 07:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

📖 The updated storybook is available here

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-people 81% 80% 0 ✔
mgt-components.src.components.mgt-person 83% 100% 0 ✔
mgt-components.src.components.mgt-person-card 78% 50% 0 ✔
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 42% 42% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 73% 0 ✔
mgt-element.dist.es6.providers.src.providers 88% 66% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 70% 72% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 84% 100% 0 ✔
mgt-element.src.utils 72% 91% 0 ➖
Summary 69% (15351 / 22161) 72% (574 / 793) 0 ➖

@Mnickii Mnickii merged commit 440211b into main Sep 3, 2024
12 checks passed
@Mnickii Mnickii deleted the fix/bug-3184 branch September 3, 2024 13:45
@release-please release-please bot mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

People picker: selectUsersById causes user dropdown to open up
2 participants
@Mnickii @musale