fix(eslint-plugin): [naming-convention] check bodyless function parameters (typescript-eslint#2675)

thomasmichaelwallace · web-flow · commit c505863ac417 · 2020-10-18T11:50:06.000-07:00
diff --git a/packages/eslint-plugin/src/rules/naming-convention.ts b/packages/eslint-plugin/src/rules/naming-convention.ts
@@ -529,10 +529,11 @@ export default util.createRule<Options, MessageIds>({
       // #endregion function
 
       // #region parameter
-
-      'FunctionDeclaration, TSDeclareFunction, FunctionExpression, ArrowFunctionExpression'(
+      'FunctionDeclaration, TSDeclareFunction, TSEmptyBodyFunctionExpression, FunctionExpression, ArrowFunctionExpression'(
         node:
           | TSESTree.FunctionDeclaration
+          | TSESTree.TSDeclareFunction
+          | TSESTree.TSEmptyBodyFunctionExpression
           | TSESTree.FunctionExpression
           | TSESTree.ArrowFunctionExpression,
       ): void {
diff --git a/packages/eslint-plugin/tests/rules/naming-convention.test.ts b/packages/eslint-plugin/tests/rules/naming-convention.test.ts
@@ -1316,5 +1316,20 @@ ruleTester.run('naming-convention', rule, {
         },
       ],
     },
+    {
+      code: `
+        declare class Foo {
+          Bar(Baz: string): void;
+        }
+      `,
+      parserOptions,
+      options: [{ selector: 'parameter', format: ['camelCase'] }],
+      errors: [
+        {
+          line: 3,
+          messageId: 'doesNotMatchFormat',
+        },
+      ],
+    },
   ],
 });
