feat!: @typescript-eslint/no-empty-object-type

mightyiam · rostislav-simonik · mightyiam · commit 3746639b9def · 2024-07-27T13:54:03.000+07:00
remove redundant `@typescript-eslint/no-empty-interface`

Co-authored-by: Rostislav Simonik &lt;rostislav.simonik@technologystudio.sk&gt;
diff --git a/src/_intentionally-unused-rules.ts b/src/_intentionally-unused-rules.ts
@@ -25,4 +25,7 @@ export const intentionallyUnusedRules: string[] = [
 
   // Covered by strict TypeScript
   '@typescript-eslint/no-invalid-this',
+
+  // Covered by `@typescript-eslint/no-empty-object-type`
+  '@typescript-eslint/no-empty-interface',
 ]
diff --git a/src/index.ts b/src/index.ts
@@ -159,10 +159,6 @@ const rules = {
       allow: [],
     },
   ],
-  '@typescript-eslint/no-empty-interface': [
-    'error',
-    { allowSingleExtends: true },
-  ],
   '@typescript-eslint/no-explicit-any': [
     'error',
     { fixToUnknown: false, ignoreRestArgs: false },
@@ -172,6 +168,10 @@ const rules = {
     'error',
     { allowWithDecorator: true },
   ],
+  '@typescript-eslint/no-empty-object-type': [
+    'error',
+    { allowInterfaces: 'with-single-extends', allowObjectTypes: 'never' },
+  ],
   '@typescript-eslint/no-floating-promises': ['error'],
   '@typescript-eslint/no-for-in-array': ['error'],
   '@typescript-eslint/no-implied-eval': ['error'],
diff --git a/src/test/_expected-exported-value.ts b/src/test/_expected-exported-value.ts
@@ -319,10 +319,6 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
         allow: [],
       },
     ],
-    '@typescript-eslint/no-empty-interface': [
-      'error',
-      { allowSingleExtends: true },
-    ],
     '@typescript-eslint/no-explicit-any': [
       'error',
       { fixToUnknown: false, ignoreRestArgs: false },
@@ -332,6 +328,10 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
       'error',
       { allowWithDecorator: true },
     ],
+    '@typescript-eslint/no-empty-object-type': [
+      'error',
+      { allowInterfaces: 'with-single-extends', allowObjectTypes: 'never' },
+    ],
     '@typescript-eslint/no-floating-promises': ['error'],
     '@typescript-eslint/no-for-in-array': ['error'],
     '@typescript-eslint/no-implied-eval': ['error'],
diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,5 +1,4 @@
 export const rulesToConsider = [
-  '@typescript-eslint/no-empty-object-type',
   '@typescript-eslint/no-inferrable-types',
   '@typescript-eslint/no-magic-numbers',
   '@typescript-eslint/no-meaningless-void-operator',

Original file line number	Diff line number	Diff line change
`@@ -25,4 +25,7 @@ export const intentionallyUnusedRules: string[] = [`
`25`	`25`
`26`	`26`	`// Covered by strict TypeScript`
`27`	`27`	`'@typescript-eslint/no-invalid-this',`
	`28`	`+`
	`29`	+ // Covered by `@typescript-eslint/no-empty-object-type`
	`30`	`+ '@typescript-eslint/no-empty-interface',`
`28`	`31`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`export const rulesToConsider = [`
`2`		`- '@typescript-eslint/no-empty-object-type',`
`3`	`2`	`'@typescript-eslint/no-inferrable-types',`
`4`	`3`	`'@typescript-eslint/no-magic-numbers',`
`5`	`4`	`'@typescript-eslint/no-meaningless-void-operator',`