Fixed ScatterChart default touchHandling crash

imaNNeo · imaNNeo · commit ae2c63c33e16 · 2021-08-27T00:09:05.000+04:30
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * **IMPROVEMENT** Again we support `longPress` touch events. check [FlTouchEvent](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/base_chart.md#fltouchevent) to see all kind of supported touch/pointer events (which can be `FlLongPressStart`, `FlLongPressMoveUpdate`, `FlLongPressEnd`, ...). Also you can check out [touch handling doc](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/handle_touches.md), #649.
 * **IMPROVEMENT** Added `mouseCursorResolver` callback in touchData classes such as [LineTouchData](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/line_chart.md#linetouchdata-read-about-touch-handling) and [BarTouchData](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/bar_chart.md#bartouchdata-read-about-touch-handling). You can change the [MouseCursor](https://api.flutter.dev/flutter/services/MouseCursor-class.html) based on the provided [FlTouchEvent](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/base_chart.md#fltouchevent) and touchResponse using this callback. (We have used this feature in [PieChartSample2](https://github.com/imaNNeoFighT/fl_chart/blob/master/repo_files/documentations/scatter_chart.md#sample-2-source-code))
 * **BUGFIX** Fixed calling `ScatterChartData.copyWith()` function problem on calculating `minX`, `maxX`, `minY` and `maxY` when they are not provided.
+* **BUGFIX** Fixed `ScatterChart` default touchHandling crash
 * **NEWS** Your donation **motivates** me to work more on the `fl_chart` and resolve more issues. Now you can [buy me a coffee](https://www.buymeacoffee.com/fl_chart)!
 
 ## 0.36.4
diff --git a/lib/src/chart/scatter_chart/scatter_chart.dart b/lib/src/chart/scatter_chart/scatter_chart.dart
@@ -77,11 +77,11 @@ class _ScatterChartState extends AnimatedWidgetBaseState<ScatterChart> {
     if (!desiredTouch || touchResponse == null || touchResponse.touchedSpot == null) {
       setState(() {
         touchedSpots = [];
-        return;
       });
+      return;
     }
     setState(() {
-      touchedSpots = [touchResponse!.touchedSpot!.spotIndex];
+      touchedSpots = [touchResponse.touchedSpot!.spotIndex];
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,11 @@ class _ScatterChartState extends AnimatedWidgetBaseState<ScatterChart> {`
`77`	`77`	`if (!desiredTouch \|\| touchResponse == null \|\| touchResponse.touchedSpot == null) {`
`78`	`78`	`setState(() {`
`79`	`79`	`touchedSpots = [];`
`80`		`- return;`
`81`	`80`	`});`
	`81`	`+ return;`
`82`	`82`	`}`
`83`	`83`	`setState(() {`
`84`		`- touchedSpots = [touchResponse!.touchedSpot!.spotIndex];`
	`84`	`+ touchedSpots = [touchResponse.touchedSpot!.spotIndex];`
`85`	`85`	`});`
`86`	`86`	`}`
`87`	`87`