stopgap: Replace validation exceptions with warnings

chriddyp · chriddyp · commit b95cc89dce6e · 2015-05-27T12:21:18.000-04:00
diff --git a/plotly/tests/test_core/test_graph_objs/test_annotations.py b/plotly/tests/test_core/test_graph_objs/test_annotations.py
@@ -6,6 +6,7 @@
 
 """
 from __future__ import absolute_import
+import warnings
 
 from nose.tools import raises
 from plotly.graph_objs import *
@@ -34,14 +35,10 @@ def test_dict_instantiation():
     Annotations([{'text': 'annotation text'}])
 
 
-@raises(PlotlyDictKeyError)
 def test_dict_instantiation_key_error():
-    print(Annotations([{'not-a-key': 'anything'}]))
-
-
-@raises(PlotlyDictValueError)
-def test_dict_instantiation_key_error():
-    print(Annotations([{'font': 'not-a-dict'}]))
+    with warnings.catch_warnings(True) as w:
+        print(Annotations([{'not-a-key': 'anything'}]))
+        assert(len(w) > 1)
 
 
 @raises(PlotlyListEntryError)
@@ -73,9 +70,9 @@ def test_validate():
     annotations.validate()
 
 
-@raises(PlotlyDictKeyError)
 def test_validate_error():
     annotations = Annotations()
     annotations.append({'not-a-key': 'anything'})
-    annotations.validate()
-
+    with warnings.catch_warnings(True) as w:
+        annotations.validate()
+        assert len(w) > 1
diff --git a/plotly/tests/test_core/test_graph_objs/test_data.py b/plotly/tests/test_core/test_graph_objs/test_data.py
@@ -6,6 +6,7 @@
 
 """
 from __future__ import absolute_import
+import warnings
 
 from nose.tools import raises
 from plotly.graph_objs import *
@@ -38,14 +39,10 @@ def test_dict_instantiation():
     Data([{'type': 'scatter'}])
 
 
-@raises(PlotlyDictKeyError)
 def test_dict_instantiation_key_error():
-    print(Data([{'not-a-key': 'anything'}]))
-
-
-@raises(PlotlyDictValueError)
-def test_dict_instantiation_key_error():
-    print(Data([{'marker': 'not-a-dict'}]))
+    with warnings.catch_warnings(True) as w:
+        print(Data([{'not-a-key': 'anything'}]))
+        assert len(w) > 1
 
 
 @raises(PlotlyDataTypeError)
@@ -82,9 +79,9 @@ def test_validate():
     data.validate()
 
 
-@raises(PlotlyDictKeyError)
 def test_validate_error():
     data = Data()
     data.append({'not-a-key': 'anything'})
-    data.validate()
-
+    with warnings.catch_warnings(True) as w:
+        data.validate()
+        assert len(w) > 1
diff --git a/plotly/tests/test_core/test_graph_objs/test_error_bars.py b/plotly/tests/test_core/test_graph_objs/test_error_bars.py
@@ -6,6 +6,7 @@
 
 """
 from __future__ import absolute_import
+import warnings
 
 from nose.tools import raises
 from plotly.graph_objs import *
@@ -46,6 +47,7 @@ def test_instantiate_error_y():
            width=5)
 
 
-@raises(PlotlyDictKeyError)
 def test_key_error():
-    ErrorX(value=0.1, typ='percent', color='red')
+    with warnings.catch_warnings(True) as w:
+        ErrorX(value=0.1, typ='percent', color='red')
+        assert len(w) > 1
